Update postgresql_type.go#3838
Closed
theAnuragMishra wants to merge 1 commit intosqlc-dev:mainfrom
theAnuragMishra:main
Closed
Update postgresql_type.go#3838theAnuragMishra wants to merge 1 commit intosqlc-dev:mainfrom theAnuragMishra:main
theAnuragMishra wants to merge 1 commit intosqlc-dev:mainfrom
theAnuragMishra:main
Conversation
Check notNull and emitPointersForNull before checking postgres driver
dosubot
bot
added
size:S
|
Hi, it looked like you took a stab at #3837 thank you for giving it a shot Why was this closed? I can see there is a lot of tests there fails, the question should then be if the new output is the desired or not? Is it to big of a breaking change? should it be behind a new flag? It could be nice if it could be reopened so we can have the discausssion |
Contributor
Author
|
Hey @benjaco !! I didn't want to just steal your idea. I had the same problem (time.Time instead of *time.Time being emitted). So I did a Google search that took me to your issue. I had done this kind of a pr before for sqlc. So I decided to do another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check notNull and emitPointersForNull before checking postgres driver